Fix (peer) dependencies

[marvinruder]

• Declare prop-types as a dependency of @nivo/core (as recommended in their README)
• Declare react as a peer dependency of @nivo/tooltip
• Declare correct version of pnpm
• Update lockfile

Fixes #2401

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nivo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 6, 2024 6:07pm

[marvinruder]

For more details on the prop-types dependency, see facebook/prop-types#44.

To validate that all peer dependencies within the @nivo vendor scope are met, I used the following snippet:

// Place this .mjs file in the `packages` folder

import fs from 'fs'
import path, { dirname } from 'path'
import { fileURLToPath } from 'url'

const __filename = fileURLToPath(import.meta.url)
const __dirname = dirname(__filename)

const folders = fs.readdirSync(__dirname).filter(f => {
    return fs.statSync(path.join(__dirname, f)).isDirectory()
})

for await (const folder of folders) {
    const packageJson = JSON.parse(
        fs.readFileSync(path.join(__dirname, folder, 'package.json'), 'utf8')
    )
    const dependencies = Object.keys(packageJson.dependencies ?? {})
    const peerDependencies = Object.keys(packageJson.peerDependencies ?? {})
    const nivoDependencies = Object.keys(packageJson.dependencies ?? {}).filter(dep =>
        dep.startsWith('@nivo/')
    )
    for await (const dep of nivoDependencies) {
        const depPackageJson = JSON.parse(
            fs.readFileSync(
                path.join(__dirname, dep.replace(/^@nivo\//, ''), 'package.json'),
                'utf8'
            )
        )
        const depPeerDependencies = Object.keys(depPackageJson.peerDependencies ?? {})
        depPeerDependencies.forEach(peerDep => {
            if (!peerDependencies.includes(peerDep) && !dependencies.includes(peerDep)) {
                throw new Error(
                    `@nivo/${folder} has a dependency on ${dep}, which declares ${peerDep} as its peer dependency. ` +
                        `However, @nivo/${folder} does not declare ${peerDep} as its dependency or peer dependency. Fix it.`
                )
            }
        })
    }
}

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eca9bac:

Sandbox	Source
nivo	Configuration

[marvinruder]

Just imported the packages @nivo/core@https://pkg.csb.dev/plouc/nivo/commit/eca9bac0/@nivo/core/_pkg.tgz and @nivo/sunburst@https://pkg.csb.dev/plouc/nivo/commit/eca9bac0/@nivo/sunburst/_pkg.tgz into my project and I can confirm that this indeed solves #2401 for me without any additional declarations in .yarnrc.yml.

PS: Did the same with https://github.com/ollwenjones/nivo-0830-test, and I can confirm this also fixes the issue with pnpm.

[plouc]

LGTM, thank you for investigating and solving the issue.