Fix area rendering disparity of line canvas compared to line svg #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d17172c:
|
|
Here is another example from the Fixed New: Old: |
This was referenced Jun 3, 2024
This was referenced Jun 3, 2024
This was referenced Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the inconsistent rendering of
enableAreawhen comparing SVG to Canvas, seen below is a example of the issue. The SVG line renders the area correctly when using a stacked line graph but the current implementation of the Canvas line renders it improperly.This fix will make the canvas version conform with how the svg version is displayed.
SVG Line Area example (Current Good ✔️):
Canvas Line Area example (Current Not Good ❌):
Canvas Line Area example (Fixed Good ✔️):
