Add useUTC to types
#690
Merged
Add useUTC to types
#690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After some messing around with Nivo and line charts, I had a issue where I discovered the dates I was passing in were being converted to the clients timezone, even though I wasn't supplying a timezone with the date and these dates I was passing in were actually already correct. To get around this we discovered a `useUTC` option which we set to false. Although it seems like its missing from the types.
plouc
requested changes
Oct 19, 2019
plouc
approved these changes
Oct 19, 2019
|
Thank you @eknowlton! |
|
Thank you for such a awesome library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some messing around with Nivo and line charts, I had a issue where I discovered the dates I was passing in were being converted to the clients timezone, even though I wasn't supplying a timezone with the date and these dates I was passing in were actually already correct. To get around this we discovered a
useUTCoption which we set tofalse.Although it seems like its missing from the types.