Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sankey): Support complete configuration of the tooltips #78

Merged
merged 1 commit into from
Oct 20, 2017

Conversation

bripkens
Copy link
Contributor

This is the last PR for issue #71. It will make tooltips configurable for Sankey nodes and links via two additional (optional) props:

<Sankey
        {...commonProperties}
        nodeTooltip={node => <span>Custom tooltip for node: {node.id}</span>}
        linkTooltip={node => (
            <span>
                Custom tooltip for link: {node.source.id} to {node.target.id}
            </span>
        )}
    />

In combination with the theme prop, is allows full control over tooltip content and style.

@plouc
Copy link
Owner

plouc commented Oct 20, 2017

wow! thank you for all those contributions!
Can you just rebase this PR against the master please?

@bripkens bripkens force-pushed the custom-sankey-tooltips branch from b8d4e6c to cc05d88 Compare October 20, 2017 16:41
@bripkens
Copy link
Contributor Author

@plouc: Done! :)

Any chance you could make a new release of nivo after merging this? I'd very much appreciate it :)

@plouc plouc merged commit f3aecf6 into plouc:master Oct 20, 2017
@bripkens bripkens deleted the custom-sankey-tooltips branch October 20, 2017 16:47
@plouc
Copy link
Owner

plouc commented Oct 20, 2017

It's a little bit late in my time zone now, but I'll try to release all this good stuff this week-end.

@plouc
Copy link
Owner

plouc commented Oct 21, 2017

@bripkens I released [email protected]

@plouc
Copy link
Owner

plouc commented Oct 21, 2017

I've also published the storybook which now includes the new stories you added.

@bripkens
Copy link
Contributor Author

That's awesome. Thank you @plouc!

@SouhaibBenFarhat
Copy link

@bripkens I'm a bit late guys, But I want to thank bripkens for this great MR, you saved my life man.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants