Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(calendar): add monthSpacing prop #964

Merged
merged 3 commits into from
Jun 22, 2020
Merged

feat(calendar): add monthSpacing prop #964

merged 3 commits into from
Jun 22, 2020

Conversation

fguitton
Copy link
Contributor

This PR adds the prop monthSpacing to @nivo/calendar as an option to add spacing between months in the rendered output.
image

@fguitton fguitton force-pushed the feat/calendar-month-spacing branch from 470d269 to 8b24062 Compare May 19, 2020 13:14
@fguitton
Copy link
Contributor Author

Hello ? Anybody here ? 😄
Not sure who is supposed to review this, would it be @plouc ?

@plouc plouc added the 📆 calendar @nivo/calendar package label Jun 20, 2020
@wyze
Copy link
Contributor

wyze commented Jun 22, 2020

Looks good! I added the same prop to the website so users can play with it, as well as updated the types.

@wyze wyze changed the title Add month spacing to @nivo/calendar feat(calendar): add monthSpacing prop Jun 22, 2020
@wyze wyze merged commit 8f55046 into plouc:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
📆 calendar @nivo/calendar package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fguitton @wyze @plouc