Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example component #1439

Merged
merged 2 commits into from
May 11, 2023
Merged

Example component #1439

merged 2 commits into from
May 11, 2023

Conversation

abernier
Copy link
Member

@abernier abernier commented May 11, 2023 •
edited
Loading

Note Merged
see <Example> doc

Why / What

It's always simpler to start with something. Something that works and is simple: a friendly Example.

In order to ease the CONTRIBUTING experience, provide a simple "counter" Example sample component, with:

  • src code
  • story
  • README documentation
image

Checklist

  • Documentation updated
  • Storybook entry added
  • Ready to be merged
  • .github/PULL_REQUEST_TEMPLATE.md "(see an example)" links for Documentation and Storybook tasks
  • "Open in Codespace" link to CONTRIBUTING
  • README disclaimer :warning: fix
  • A CONTRIBUTING link in the README

    If you make a component that is generic enough to be useful to others, think about making it available here through a PRCONTRIBUTING!

@vercel
Copy link

vercel bot commented May 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 0:43am

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 11, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit da47fbf:

Sandbox Source
condescending-solomon-z4cqwh Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@abernier abernier force-pushed the abernier/example branch from 55c8cba to 3b5d996 Compare May 11, 2023 12:41
@abernier abernier force-pushed the abernier/example branch from 3b5d996 to da47fbf Compare May 11, 2023 12:42
@abernier abernier marked this pull request as ready for review May 11, 2023 12:45
@abernier abernier merged commit a5e16eb into master May 11, 2023
@github-actions
Copy link

🎉 This PR is included in version 9.68.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@abernier abernier deleted the abernier/example branch May 11, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abernier