Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallax.scrollTo only scrolls to initial position #1517

Closed
pikilon opened this issue May 18, 2021 · 7 comments
Closed

Parallax.scrollTo only scrolls to initial position #1517

pikilon opened this issue May 18, 2021 · 7 comments
Labels
status: won't fix This will not be worked on
Milestone

Comments

@pikilon
Copy link

pikilon commented May 18, 2021

🐛 Bug Report

It is not possible to Scroll using the parallax.scrollTo

To Reproduce

  1. open the spring documentation official example
    https://codesandbox.io/s/github/pmndrs/react-spring/tree/master/demo/src/sandboxes/parallax-vert

  2. click on the Server image inside the output

  3. It does nothing

Expected behavior

Scrolls to the second offset page with a bash terminal image inside

Environment

"@react-spring/parallax": 9.1.2

@joshuaellis
Copy link
Member

With all due respect, these bug reports are really unclear.

Can you try and thoroughly explain your bug, why you think it's a bug and why you think the expected behaviour is what you've written.

@pikilon
Copy link
Author

pikilon commented May 18, 2021

I have update it

@joshuaellis joshuaellis added template: bug This issue might be a bug v9 labels May 18, 2021
@joshuaellis joshuaellis added this to the v9.3.0 milestone May 18, 2021
@kindoflew
Copy link
Collaborator

kindoflew commented May 19, 2021

It seems like the recent changes (#1458 and #1455) that fix both this and #1516 didn't make it into 9.1.2. If you update the version in the sandboxes to 9.2.0 everything should work.

@joshuaellis
Copy link
Member

To add to that, there are a fair few fixes in our beta which is what @kindoflew is referring to.

@joshuaellis
Copy link
Member

Although these sandboxes use the most up to date version of the library (9.2.0-beta.6?) and the issue is there 😞

@pikilon
Copy link
Author

pikilon commented May 19, 2021

I think the sandboxes are in the latest stable version, which is 9.1.2.
Every user installing this package will have these issues.

@joshuaellis
Copy link
Member

Ah my bad, yep updating them to our beta works as intended – https://codesandbox.io/s/lively-resonance-wp5fj?file=/src/App.tsx

@joshuaellis joshuaellis added status: won't fix This will not be worked on and removed template: bug This issue might be a bug labels May 19, 2021
cameron-martin pushed a commit to cameron-martin/react-spring that referenced this issue May 10, 2022
Replace use of multi target react-spring to avoid peer dependency
warnings. Update package.json files, JS imports and lock deps

Close #1505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: won't fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants