Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: assign controller to provided ref for useTransition #1475

Merged
merged 4 commits into from
Apr 28, 2021
Merged

fix: assign controller to provided ref for useTransition #1475

merged 4 commits into from
Apr 28, 2021

Conversation

martinkutter
Copy link
Contributor

Why

Injected ref is not updated with controller for useTransition, as seen in #1453

What

This pull request ensures that injected ref is updated.

Checklist

  • Documentation updated
  • Demo added
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 28, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b7226f1:

Sandbox Source
spring-card Configuration
spring-goo-blobs Configuration
spring-flip-card Configuration
spring-slide Configuration
spring-draggable-list Configuration
spring-cards-stack Configuration
spring-viewpager Configuration
spring-simple-transition Configuration
spring-image-fade Configuration
spring-list-reordering Configuration

@joshuaellis joshuaellis changed the base branch from master to beta April 28, 2021 18:35
@joshuaellis joshuaellis linked an issue Apr 28, 2021 that may be closed by this pull request
useChain does not work as expected for transitions #1453
Closed
@joshuaellis joshuaellis merged commit 8b36268 into pmndrs:beta Apr 28, 2021
@joshuaellis
Copy link
Member

Thanks for the great contribution ⭐

joshuaellis added a commit that referenced this pull request Apr 29, 2021
@joshuaellis
Revert "fix: assign controller to provided ref for useTransition (#1475…
10aa771 
…)"

This reverts commit 8b36268.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useChain does not work as expected for transitions
2 participants
@martinkutter @joshuaellis