[fix] Delay conflict with Trail in useTransition

[joshuaellis]

Why

resolves #1099

What

Since we handle the trail prop in useTransition and pass that as our delay prop to the Controller we therefore need to call the original delay prop from the props passed and add that to the payload to ensure timings are correct.

Checklist

• Ready to be merged

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 663b94d:

Sandbox	Source
spring-card	Configuration
spring-goo-blobs	Configuration
spring-flip-card	Configuration
spring-slide	Configuration
spring-draggable-list	Configuration
spring-cards-stack	Configuration
spring-viewpager	Configuration
spring-simple-transition	Configuration
spring-image-fade	Configuration
spring-list-reordering	Configuration
pensive-borg-8udov	Issue #1099
muddy-fog-solxl	Issue #1099
friendly-cerf-3skwc	Issue #1099
quiet-butterfly-hi8c5	Issue #1099

[joshuaellis]

@leinelissen it'd be great if you could confirm this works as expected? Check this slightly modified sandbox out, it uses the PR as react-spring – https://codesandbox.io/s/youthful-boyd-8u981?file=/src/App.js

[leinelissen]

@joshuaellis Looks like how I was expecting things to work, thanks so much for looking at this. As per your phase styles comment: I found that delay and trail were part of the Typescript bindings for the phase styles object, and as such I was confused on whether this was an accepted setup. I am completely fine with it being static for the transition.

[joshuaellis]

Yeah I did find that odd, I think it's because at the route of phases it's just our to object with I believe is based on a [key:string]: any format to allow loads of flexibility... Before I merge this I might check out we have a "not allowed" list of keywords 🤔

But i'm glad this has solved your issue.

[joshuaellis]

No i've checked, because its to just CSS props you might wanna use, we let most things go through, I guess thats why documentation is important 😅

[leinelissen]

Right! I've seeing ghosts then 😅 Thanks again for looking at this.