Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase External r3f components on docs #3377

Open
jo-chemla opened this issue Oct 11, 2024 · 2 comments
Open

Showcase External r3f components on docs #3377

jo-chemla opened this issue Oct 11, 2024 · 2 comments

Comments

@jo-chemla
Copy link

jo-chemla commented Oct 11, 2024

I've never come across an up-to-date list of r3f components created by contributors outside of the pmndrs org - something along the lines of awesome-react-three-fiber, whose last update is 3yo. Would it make sense to showcase interesting and re-usable r3f components created outside of the pmndrs org somewhere in the docs? It could probably be located under the Getting started section.

This could include from the top of my mind:

Plus these ones I discovered searching:

Regarding citation of existing pmndrs wrappers for projects of external contributors like gkjohnson three-mesh-bvh/Bvh or three-gpu-pathtracer/pmndrs/react-three-gpu-pathtracer component, these are already in the drei doc, so probably no need to add them to this list.

I can come up with a quick PR if this is deemed to make sense!

jo-chemla added a commit to jo-chemla/react-three-fiber that referenced this issue Oct 11, 2024
@jo-chemla
Copy link
Author

Just made a PR here: #3378 🎉
Demo is visible here:

@jo-chemla
Copy link
Author

Two final notes:

  • I've edited images so they have the same aspect ratio than codesanboxes screenshots. I've tried to do it in markdown but only solution I found was to pass to <Img> components the props className="aspect-[16/9] object-cover" width="1763" height="926"
  • I've spotted the fetchCSB function that is applied here. and I am assuming this props merging should be the other way around: const merged = { ...data, ...props } so user-provided props do not get replaced by those returned by the codesandbox API calls, like eg screenshot_url - if the user pass it to the Codesandbox component, then it should not be overwritten by the api call. Should I push a quickfix PR for this?

This doc update is ready to merge from my point-of-view!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant