-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate equalityFn and add createWithEqualityFn #1945
Merged
+145
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 31235a6:
|
Size Change: +3.11 kB (+8%) 🔍 Total Size: 43.2 kB
ℹ️ View Unchanged
|
5 tasks
This was referenced Aug 3, 2023
andreasgerstmayr
added a commit
to andreasgerstmayr/perses
that referenced
this pull request
May 23, 2024
useStore() with equalityFn is deprecated: pmndrs/zustand#1937 pmndrs/zustand#1945 Signed-off-by: Andreas Gerstmayr <[email protected]>
andreasgerstmayr
added a commit
to andreasgerstmayr/perses
that referenced
this pull request
May 23, 2024
useStore() with equalityFn is deprecated: pmndrs/zustand#1937 pmndrs/zustand#1945 Signed-off-by: Andreas Gerstmayr <[email protected]>
Merged
6 tasks
github-merge-queue bot
pushed a commit
to perses/perses
that referenced
this pull request
May 24, 2024
…2019) useStore() with equalityFn is deprecated: pmndrs/zustand#1937 pmndrs/zustand#1945 Signed-off-by: Andreas Gerstmayr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues or Discussions
Fixes #1937
Summary
See #1937
Caveat 1:
createWithEqualityFn
has nothing to do withsubscribeWithSelector
middleware and we still need to specify equalityFn such asshallow
forsubscribeWithSelector
.Check List
yarn run prettier
for formatting code and docs