Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs related to SSR/Hydration and SSR Apps #2298

Merged
merged 54 commits into from
Feb 8, 2024

Conversation

dbritto-dev
Copy link
Collaborator

Related Issues or Discussions

Update docs related to #2277

Check List

  • yarn run prettier for formatting code and docs

Copy link

vercel bot commented Jan 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 3:47pm

Copy link

codesandbox-ci bot commented Jan 20, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 45ef018:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration
@pavlobu/zustand demo Configuration

@dbritto-dev dbritto-dev changed the title Update docs related to getInitialState Update docs related to SSR/Hydration and SSR Apps Jan 20, 2024
Copy link
Collaborator

@sewera sewera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that this PR is not done yet, but I had some spare time, so I figured you can use some quick feedback :)

docs/guides/ssr-and-hygration.md Outdated Show resolved Hide resolved
docs/guides/ssr-and-hygration.md Outdated Show resolved Hide resolved
src/traditional.ts Show resolved Hide resolved
@dbritto-dev dbritto-dev marked this pull request as ready for review February 3, 2024 06:40
@dbritto-dev dbritto-dev self-assigned this Feb 3, 2024
@dbritto-dev dbritto-dev added the documentation Improvements or additions to documentation label Feb 3, 2024
@sewera
Copy link
Collaborator

sewera commented Feb 7, 2024

@dbritto-dev I didn't know how to unmark a resolved conversation, or mark it as unresolved, but I've put a comment on nextjs.md@26-27 and I think you didn't see it because it was hidden.

Co-authored-by: Blazej Sewera <[email protected]>
docs/guides/nextjs.md Outdated Show resolved Hide resolved
dbritto-dev and others added 2 commits February 7, 2024 10:39
Co-authored-by: Charles Kornoelje <[email protected]>
Copy link
Collaborator

@charkour charkour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very good work. Thank you!

I wish this guide was around when we began ustand Zustand with Next.js 😄

Copy link
Collaborator

@sewera sewera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, as always @dbritto-dev :)

@dai-shi
Copy link
Member

dai-shi commented Feb 8, 2024

Thanks everyone! Let's merge this and continue improving docs!

@dai-shi dai-shi merged commit f64a111 into pmndrs:main Feb 8, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants