Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset thumbnail decorations with MPV-EASY #81

Closed
First-Dan opened this issue Jan 24, 2023 · 9 comments
Closed

Offset thumbnail decorations with MPV-EASY #81

First-Dan opened this issue Jan 24, 2023 · 9 comments

Comments

@First-Dan
Copy link

First-Dan commented Jan 24, 2023

I'm using modern osc.
I tried all the forks available and they all show the same problem,
Don't know if it has anything to do with it but my monitor is a 16:10

@First-Dan First-Dan changed the title Thumb ackground seems off Thumb background seems off Jan 24, 2023
@po5
Copy link
Owner

po5 commented Jan 24, 2023

There's a latency inherent in the current rendering model, scripts can avoid it by using the custom render functionality but the current implementation is a pain to deal with.
There's a PR to uosc that uses it, and it does seem to fix the issue.
I've thought about forwarding serialized code to the UI script as a way to truly execute within their render loop without requiring extra work from them, but I'm sure there's a less intrusive solution.
Suggestions appreciated.

@tomasklaen
Copy link

Regarding that PR, I'm still waiting for your verdict on that proposed new API :) → tomasklaen/uosc#353 (comment)

@First-Dan
Copy link
Author

@po5 Can you link me the PR please? Couldn't find it.

@christoph-heinrich
Copy link
Contributor

@First-Dan tomasklaen already linked to it in the comment above yours.

@First-Dan
Copy link
Author

It's working now, but I didn't use the solution provided by the PR becasue i didn't know what to do with it (lol).
I managed to fix it by switching to the original mpv player, because i was using a different fork of mpv called mpv easy player which also had support for vanilla UI and scripts, except for Thumbfast. I guess @po5 had nothing to do with this issue from the beginning but it was something to do with that fork.

Thank you everyone for your help nonetheless!

@po5
Copy link
Owner

po5 commented Apr 30, 2023

@First-Dan Were you actually using thumbfast in that screenshot?
I'd like to copy your configuration to replicate it, if you can link to the scripts you were using.
I thought this was #11, but if the thumbnail is always off it's more likely an issue in the UI script.

Okay, MPV-EASY does something weird that breaks decoration positioning.
mpv-shot0002

@po5 po5 changed the title Thumb background seems off Offset thumbnail decorations with MPV-EASY May 3, 2023
@po5 po5 mentioned this issue Jul 26, 2023
@po5
Copy link
Owner

po5 commented Jul 26, 2023

@First-Dan and any other users of MPV-EASY, can you confirm that 74cba1f fixes the issue? (update osc.lua)
This misalignment is what happens when the default ASS alignment is 9 (top-right), Syncplay had 1 (bottom-right). We expected it to be 7 (top-left), and that is now explicitly specified.

@po5
Copy link
Owner

po5 commented Jul 28, 2023

Confirmed to work here 1-minute-to-midnight/mpv-modern-x-compact#7 (comment)

@po5 po5 closed this as completed Jul 28, 2023
@po5
Copy link
Owner

po5 commented Aug 4, 2023

It was caused by non-default osd-align-x/y values in both Syncplay and MPV-EASY.

https://github.com/422658476/MPV-EASY-Player/blob/f281e7ace9b276dc4aee595c8da1b2093a01f491/mpv-easy-data/rjno1.conf#L11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants