Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncplay bug #100

Closed
ymn236 opened this issue Jul 26, 2023 · 3 comments
Closed

Syncplay bug #100

ymn236 opened this issue Jul 26, 2023 · 3 comments

Comments

@ymn236
Copy link

ymn236 commented Jul 26, 2023

This happens when using the script with Syncplay:

2

@po5
Copy link
Owner

po5 commented Jul 26, 2023

Are you sure this is a Syncplay issue? It seems very similar to #81, a bug with the MPV-EASY frontend.

Edit: Okay can reproduce with Syncplay and vanilla OSC fork on Linux.

po5 added a commit that referenced this issue Jul 26, 2023
Some clients (Syncplay #100) seemingly mess with the default alignment.
@po5
Copy link
Owner

po5 commented Jul 26, 2023

It seems like Syncplay somehow messes with the default ASS alignment, as adding an explicit elem_ass:an(7) to our thumbnail fixes it. I've done that in the above commit, please reopen if you encounter this issue again.

I suspect this is what was happening with MPV-EASY too, thanks for submitting this as it was much easier for me to reproduce and debug.

@Et0h
Copy link

Et0h commented Aug 4, 2023

Based on this thread I've been able to determine that the issue was that Syncplay in effect ran mpv with --osd-align-y=bottom but thumbfast was only designed to accommodate --osd-align-y=top. I can confirm that the above commit fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants