Pass an owned value and an egui::Ui
to Plugin::run()
#205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the API of
Plugin::run()
in two ways:Plugin
instead of a mutable reference. Based on my experience for similar APIs (e.g. Rerun'slist_item
), it can be very useful for implementer to have an owned value. For example it makes it possible for the plugin to carry adyn FnOnce
. This works because plugins are only ever called once. The trick to keep the trait object safe is to force the value to be wrapped in aBox
. That's how things are already, so I figured this is acceptable.egui::Ui
instead of anegui::Painter
. This enables using egui to create more complex interactions within the view, for example hover tooltips etc. (see ProvidePlugin::run()
with anegui:Ui
#197).Fixes #197