Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change type name delimiters from <> () [] to _ #904

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

daxartio
Copy link
Contributor

This change aligns with OpenAPI object naming conventions, where special characters like <, (), and [] can cause issues in schema generation and parsing. Replacing them with underscores (_) ensures compatibility with OpenAPI specifications, improving both readability and tool support.

This update maintains functionality while adhering to standard naming rules for better interoperability.

#671
#670
#774

@daxartio
Copy link
Contributor Author

Hi, @sunli829
Could you please take a look at this PR and provide your advice? Thanks in advance!

@sunli829 sunli829 merged commit 97c65a8 into poem-web:master Nov 25, 2024
@sunli829
Copy link
Collaborator

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants