Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow specifying schema in pl.scan_ndjson #10963

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

sd2k
Copy link
Contributor

@sd2k sd2k commented Sep 7, 2023

Relates to #8279.

I'm not 100% sure about the Python schema type annotation, there are a few different variations in this file but this seems to make the most sense? Happy to adjust though.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Sep 7, 2023
Relates to pola-rs#8279.

I'm not 100% sure about the Python schema type annotation, there are a
few different variations in this file but this seems to make the most
sense? Happy to adjust though.
@sd2k sd2k force-pushed the scan-ndjson-allow-explicit-schema branch from 43fd396 to 617e751 Compare September 7, 2023 06:30
@sd2k sd2k marked this pull request as ready for review September 7, 2023 06:30
@ritchie46
Copy link
Member

Thanks you @sd2k. It is going in. 👍

@ritchie46 ritchie46 merged commit 57139eb into pola-rs:main Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants