Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement BinaryView and Utf8View in polars-arrow #13243

Merged
merged 13 commits into from
Jan 5, 2024
Merged

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Dec 25, 2023

The goal is to replace the current Arrow (Large)String type with a string type that allows a union between an inlined small string and an offset to a string that is allocated somewhere else.

This would prevent the terrible performance we have when filtering/gathering large string data as that forces a copy of all bytes. Second this type also allows string interning. As duplicates can only be stored once in the buffer and then we can point to that string multiple times.

Needless to say, still a lot to do.

Relevant arrow discussion here: https://lists.apache.org/thread/w88tpz76ox8h3rxkjl4so6rg3f1rv7wt
Whether or not they will go forward with this, we will.

It seems the BinView type is formally accepted in arrow! 🎉

@ritchie46 ritchie46 requested a review from orlp as a code owner December 25, 2023 13:20
@ritchie46 ritchie46 marked this pull request as draft December 25, 2023 13:32
@ritchie46 ritchie46 changed the title WIP: new string type feat: implement BinaryView and Utf8View in polars-arrow Jan 5, 2024
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jan 5, 2024
@ritchie46 ritchie46 marked this pull request as ready for review January 5, 2024 11:46
@ritchie46 ritchie46 merged commit 6f77f94 into main Jan 5, 2024
17 checks passed
@ritchie46 ritchie46 deleted the binview branch January 5, 2024 12:28
@c-peters c-peters added the accepted Ready for implementation label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants