Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(rust): Fix a feature gate for lz4 compression in polars-parquet #15565

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

ozgrakkurt
Copy link
Contributor

Feature check for inner_compress function has a typo for "lz4" and this is causing a compilation error if only "lz4" feature is enabled.

Feature check for `inner_compress` function has a typo for "lz4" and this is causing a compilation error if only "lz4" feature is enabled.
@github-actions github-actions bot added the fix Bug fix label Apr 9, 2024
Copy link

codspeed-hq bot commented Apr 9, 2024

CodSpeed Performance Report

Merging #15565 will degrade performances by 12.11%

Comparing ozgrakkurt:patch-1 (86ce2a0) with main (b91dedb)

Summary

❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main ozgrakkurt:patch-1 Change
test_sort_nan_1942 1 ms 1.2 ms -12.11%

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (b91dedb) to head (86ce2a0).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15565   +/-   ##
=======================================
  Coverage   81.15%   81.16%           
=======================================
  Files        1367     1367           
  Lines      175313   175313           
  Branches     2530     2530           
=======================================
+ Hits       142282   142290    +8     
+ Misses      32555    32548    -7     
+ Partials      476      475    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@stinodego stinodego changed the title fix(parquet): fix typo in feature check build(rust): Fix a feature gate for lz4 compression Apr 10, 2024
@github-actions github-actions bot added build Changes that affect the build system or external dependencies rust Related to Rust Polars labels Apr 10, 2024
@stinodego stinodego changed the title build(rust): Fix a feature gate for lz4 compression build(rust): Fix a feature gate for lz4 compression in polars-parquet Apr 10, 2024
@stinodego stinodego merged commit 97c61fe into pola-rs:main Apr 10, 2024
21 of 22 checks passed
@stinodego stinodego removed the fix Bug fix label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants