Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IpcWriter with compression #1769

Merged

Conversation

illumination-k
Copy link
Contributor

I implemented with_compression in IPC Writer and its test related to #1539.
If necessary, I would like to expose the Python API.

@ritchie46
Copy link
Member

If necessary, I would like to expose the Python API.

That would be great. :)

@ritchie46
Copy link
Member

Already reviewed the Rust code. Looks good! 👍

@ritchie46 ritchie46 mentioned this pull request Nov 14, 2021
@illumination-k
Copy link
Contributor Author

Now parquet Compression is re-exported as Compression, it may occur conflicts with others. Maybe is it better to rename like ParquetCompression?

pub use write::Compression;

@ritchie46
Copy link
Member

Now parquet Compression is re-exported as Compression, it may occur conflicts with others. Maybe is it better to rename like ParquetCompression?

pub use write::Compression;

Yes, I think that's a good idea. Maybe even create our own enums, so that we don't have an API break, when arrow2 adds an option.

py-polars/src/dataframe.rs Outdated Show resolved Hide resolved
@ritchie46
Copy link
Member

Thanks a lot!

@ritchie46 ritchie46 merged commit 80beb1c into pola-rs:master Nov 14, 2021
@illumination-k illumination-k deleted the feature/ipc-writer-compression branch November 14, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants