-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Bump Rust toolchain to nightly-2024-09-29
#19006
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19006 +/- ##
==========================================
- Coverage 79.87% 79.86% -0.01%
==========================================
Files 1524 1524
Lines 207644 207655 +11
Branches 2904 2904
==========================================
- Hits 165851 165846 -5
- Misses 41246 41262 +16
Partials 547 547 ☔ View full report in Codecov by Sentry. |
@@ -264,7 +264,7 @@ fn decimal_serializer(array: &PrimitiveArray<i128>, scale: usize) -> impl Serial | |||
fn callback_serializer<'a, T: NativeType, const QUOTE_NON_NULL: bool>( | |||
array: &'a PrimitiveArray<T>, | |||
mut callback: impl FnMut(T, &mut Vec<u8>) + 'a, | |||
) -> impl Serializer + 'a { | |||
) -> impl Serializer<'a> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure this is equivalent? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not exactly. Doesn't have to be an issue though. Why was it needed now?
The implementation of the serializer is now static, but borrows 'a. Which, if it compiles is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a new lint that doesn't allow eliding lifetimes if the lifetime is named elsewhere in the function definition, so Serializer
has to explicitly become Serializer<'a>
. Apparently the + 'a
is no longer needed.
You can check commit by commit for the newly added lints.
There's an issue with one of the new lints that requires a few ignores. See:
rust-lang/rust-clippy#13458