Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Bump Rust toolchain to nightly-2024-09-29 #19006

Merged
merged 7 commits into from
Sep 29, 2024
Merged

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Sep 29, 2024

You can check commit by commit for the newly added lints.

There's an issue with one of the new lints that requires a few ignores. See:
rust-lang/rust-clippy#13458

@github-actions github-actions bot added build Changes that affect the build system or external dependencies python Related to Python Polars rust Related to Rust Polars labels Sep 29, 2024
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (57df7b0) to head (360cfa2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...es/polars-arrow/src/legacy/kernels/take_agg/mod.rs 50.00% 1 Missing ⚠️
...ates/polars-ops/src/chunked_array/list/sum_mean.rs 0.00% 1 Missing ⚠️
...pipe/src/executors/sinks/group_by/primitive/mod.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19006      +/-   ##
==========================================
- Coverage   79.87%   79.86%   -0.01%     
==========================================
  Files        1524     1524              
  Lines      207644   207655      +11     
  Branches     2904     2904              
==========================================
- Hits       165851   165846       -5     
- Misses      41246    41262      +16     
  Partials      547      547              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -264,7 +264,7 @@ fn decimal_serializer(array: &PrimitiveArray<i128>, scale: usize) -> impl Serial
fn callback_serializer<'a, T: NativeType, const QUOTE_NON_NULL: bool>(
array: &'a PrimitiveArray<T>,
mut callback: impl FnMut(T, &mut Vec<u8>) + 'a,
) -> impl Serializer + 'a {
) -> impl Serializer<'a> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure this is equivalent? 🤔

Copy link
Member

@ritchie46 ritchie46 Sep 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly. Doesn't have to be an issue though. Why was it needed now?

The implementation of the serializer is now static, but borrows 'a. Which, if it compiles is fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a new lint that doesn't allow eliding lifetimes if the lifetime is named elsewhere in the function definition, so Serializer has to explicitly become Serializer<'a>. Apparently the + 'a is no longer needed.

@stinodego stinodego marked this pull request as ready for review September 29, 2024 12:59
@ritchie46 ritchie46 merged commit d0963db into main Sep 29, 2024
29 checks passed
@ritchie46 ritchie46 deleted the bump-toolchain-240929 branch September 29, 2024 13:22
@c-peters c-peters added the accepted Ready for implementation label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation build Changes that affect the build system or external dependencies python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants