-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): Improve auto-initialization of credential providers #20843
base: main
Are you sure you want to change the base?
feat(python): Improve auto-initialization of credential providers #20843
Conversation
…ly aws_region is given
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20843 +/- ##
==========================================
- Coverage 79.70% 79.63% -0.07%
==========================================
Files 1569 1571 +2
Lines 223017 223166 +149
Branches 2546 2554 +8
==========================================
- Hits 177746 177724 -22
- Misses 44687 44857 +170
- Partials 584 585 +1 ☔ View full report in Codecov by Sentry. |
@nameexhaustion any reason why you are not using the CredentialProvider trait from object store? |
It is being used here - polars/crates/polars-io/src/cloud/credential_provider.rs Lines 473 to 480 in 24fccc4
We have it set up such that the Python credential providers eventually get converted into the |
CredentialProviderAWS
ifstorage_options
contains only anaws_region
config key.storage_options
contains client config keys1Footnotes
https://docs.rs/object_store/latest/object_store/enum.ClientConfigKey.html ↩