Refactor schema #2788
Merged
Refactor schema #2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
python
ritchie46
force-pushed
the
refactor_schema
branch
from
6ea2831 to
45b9c33
Compare
ritchie46
force-pushed
the
refactor_schema
branch
from
45b9c33 to
82d91c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every node in a lazy computation gets a schema. Evaluating an expression requires several schema lookups. This was backed by a
Vec. But the data in the schema is&strso there is a lot of indirection and thus cache misses. Besides that the usage of polars with regards of number of expressions ran on aDataFrameand number ofcolumnsthat are stored in aDataFramefar exceed my initial exprectations/ guesses. Both are in the millions, meaning we needO(1)instead ofO(n)schema lookups.This PR refactors the schema to be backed by IndexMap. This is a hashmap that also stores insertion order.
@ghuls FYI