Improve list builders, iteration and construction #3419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Greatly improves performance of the list builders by: jorgecarleitao/arrow2#991 - List builders now also support nested dtypes like List and Struct - Python DataFrame and Series constructor now support better nested dtype construction
github-actions
bot
added
python
Codecov Report
@@ Coverage Diff @@
## master #3419 +/- ##
==========================================
- Coverage 61.61% 61.60% -0.02%
==========================================
Files 395 396 +1
Lines 68428 68573 +145
==========================================
+ Hits 42165 42241 +76
- Misses 26263 26332 +69
Continue to review full report at Codecov.
|
ritchie46
commented
May 18, 2022
| assert pl.DataFrame( | ||
| { | ||
| "list_of_struct": [ | ||
| [{"a": 1, "b": 4}, {"a": 3, "b": 6}], |
There was a problem hiding this comment.
@cbilot creating list of structs is now a bit more ergonomic.
moritzwilksch
pushed a commit
to moritzwilksch/polars
that referenced
this pull request
May 29, 2022
* list namespace to polars-ops * Improve list builders, iteration and construction - Greatly improves performance of the list builders by: jorgecarleitao/arrow2#991 - List builders now also support nested dtypes like List and Struct - Python DataFrame and Series constructor now support better nested dtype construction * fix tests and fix struct::agg_list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greatly improves performance of the list builders
by: remove accidental quadratic null_count jorgecarleitao/arrow2#991
List builders now also support nested dtypes like List and Struct
Python DataFrame and Series constructor now support better nested dtype
construction
Fix a wrong implementation of
agg_listfor dtypeStructfixes #3415
fixes #3418