Update arrow and prepare for mutable arithmetics #3695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
python
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates arrow and refactors the
ArrayReffromArc<dyn Array>toBox<dyn Array>. The buffers holding the data remainArced.This will make it easier to benefit from our new mutable writer opportunities. See: jorgecarleitao/arrow2#1042 for more info on this topic.
Additional benefit. I noticed during refactoring that we call
ListArray::from_datavery often which does anO(n)data check on the offsets.This is now replaced with
ListArray::new_uncheckedmaking the callO(1). This likely is a perf improvement on many groupby operations.