Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: polars-lazy readability improvements #3701

Merged
merged 4 commits into from
Jun 15, 2022

Conversation

ryanrussell
Copy link
Contributor

Separated out the two code re-wordingsto make them easier to read:

  • replace_wildcard
  • excluded

Rest of the changes are mostly comments.

Best,
Ryan

@github-actions github-actions bot added python Related to Python Polars rust Related to Rust Polars labels Jun 15, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3701 (604da7b) into master (0307a57) will increase coverage by 5.33%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3701      +/-   ##
==========================================
+ Coverage   72.35%   77.69%   +5.33%     
==========================================
  Files         436      436              
  Lines       72836    72836              
==========================================
+ Hits        52704    56592    +3888     
+ Misses      20132    16244    -3888     
Impacted Files Coverage Δ
...y/src/logical_plan/optimizer/aggregate_pushdown.rs 0.00% <ø> (ø)
...s/polars-lazy/src/physical_plan/expressions/mod.rs 83.16% <ø> (+7.90%) ⬆️
polars/polars-lazy/src/utils.rs 82.05% <ø> (+32.23%) ⬆️
py-polars/src/dataframe.rs 89.00% <ø> (ø)
polars/polars-lazy/src/logical_plan/projection.rs 90.79% <100.00%> (ø)
...ars/polars-lazy/src/physical_plan/executors/mod.rs 97.18% <100.00%> (+6.33%) ⬆️
py-polars/src/series.rs 78.20% <100.00%> (ø)
...core/src/chunked_array/logical/categorical/from.rs 21.62% <0.00%> (-18.92%) ⬇️
...s/polars-core/src/chunked_array/upstream_traits.rs 73.04% <0.00%> (-2.61%) ⬇️
polars/polars-io/src/parquet/predicates.rs 68.88% <0.00%> (-2.23%) ⬇️
... and 136 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0307a57...604da7b. Read the comment docs.

@ritchie46
Copy link
Member

Thanks!

@ritchie46 ritchie46 merged commit 26e142a into pola-rs:master Jun 15, 2022
@ryanrussell ryanrussell deleted the polars-lazy-readability branch June 17, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants