-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inplace arithmetic #3709
inplace arithmetic #3709
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3709 +/- ##
==========================================
- Coverage 61.79% 61.76% -0.03%
==========================================
Files 436 437 +1
Lines 72527 72680 +153
==========================================
+ Hits 44817 44890 +73
- Misses 27710 27790 +80
Continue to review full report at Codecov.
|
If I understand, a factor of almost 2? 🚀 |
Yes! :D |
can now be in place IFF the underlying data is not shared. This is not implemented for division by literals because we compile division JIT via https://docs.rs/strength_reduce/latest/strength_reduce/. We can look into making that mutable later.
More operations will follow. Especially for long boolean chains this is interesting.
This is possible thanks to jorgecarleitao/arrow2#1061
Improvement upstream
See: jorgecarleitao/arrow2#1076