Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use quotes in pip install instruction #3820

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

thatlittleboy
Copy link
Contributor

A small PR to encourage the use of quotes around the package name during pip install. (README.md)

Under zsh,

$ pip3 install -U polars[pyarrow]

will throw an error

zsh: no matches found: polars[pyarrow]

which might throw some beginners off.

The more robust solution is to put quotes around the package name so globbing doesn't happen. And this is compatible with bash as well.

@ritchie46
Copy link
Member

Thanks!

@ritchie46 ritchie46 merged commit ca28e70 into pola-rs:master Jun 27, 2022
@thatlittleboy thatlittleboy deleted the pip-install-instruction branch June 27, 2022 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants