Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rust,python)!: Rename list namespace accesor from .arr to .list #8999

Merged
merged 4 commits into from
May 24, 2023
Merged

refactor(rust,python)!: Rename list namespace accesor from .arr to .list #8999

merged 4 commits into from
May 24, 2023

Conversation

stinodego
Copy link
Contributor

@stinodego stinodego commented May 23, 2023 •
edited
Loading

Closes #7529

Changes:

  • Rename list namespace accessor from .arr to .list, both on Python and on Rust side.

@stinodego stinodego added the highlight Highlight this PR in the changelog label May 23, 2023
@github-actions github-actions bot added the refactor Code improvements that do not change functionality label May 23, 2023
@ritchie46
Copy link
Member

PR because otherwise I'm guaranteed to get into merge conflicts.

Should be possible right? Got even the FixedSizeList in without conflicts. ^^

@stinodego
Copy link
Contributor Author

All right will do! Hold on :)

@stinodego stinodego changed the title refactor!(python): Rename list namespace accesor from .arr to .list refactor!(rust,python): Rename list namespace accesor from .arr to .list May 23, 2023
@stinodego
Copy link
Contributor Author

stinodego commented May 23, 2023 •
edited
Loading

Rust side was actually not that big. This should be ready. The global lint check is failing because the dprint mirror is down :/ I can confirm it lints fine locally.

@stinodego stinodego changed the title refactor!(rust,python): Rename list namespace accesor from .arr to .list refactor(rust,python)!: Rename list namespace accesor from .arr to .list May 23, 2023
@github-actions github-actions bot added breaking Change that breaks backwards compatibility python Related to Python Polars rust Related to Rust Polars labels May 23, 2023
@stinodego stinodego requested a review from ritchie46 May 24, 2023 05:30
@ritchie46
Copy link
Member

Rust side was actually not that big.

And the rust side is always smooth sailing right? Take a cup of coffee and simply follow compilers' instructions. ^^

@ritchie46 ritchie46 merged commit fa83125 into main May 24, 2023
@ritchie46 ritchie46 deleted the rename-arr-to-list branch May 24, 2023 06:38
Uinelj added a commit to Uinelj/lbxd-stats that referenced this pull request May 30, 2023
@Uinelj
fix: rename arr to list
784ad68 
see pola-rs/polars#8999
@stinodego stinodego mentioned this pull request Jun 2, 2023
Closed
@sorhawell sorhawell mentioned this pull request Jun 2, 2023
Closed
@gdevenyi gdevenyi mentioned this pull request Jul 7, 2023
Closed
c-peters pushed a commit to c-peters/polars that referenced this pull request Jul 14, 2023
@stinodego @c-peters
refactor(rust,python)!: Rename list namespace accesor from .arr to …
6a8399a 
…`.list` (pola-rs#8999)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@universalmind303 universalmind303 Awaiting requested review from universalmind303

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

Assignees
No one assigned
Labels
breaking Change that breaks backwards compatibility highlight Highlight this PR in the changelog python Related to Python Polars refactor Code improvements that do not change functionality rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the List namespace accessor to .list
2 participants
@stinodego @ritchie46