-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: Release 0.7.0 #308
Conversation
(The checks fail because of the snapshot test including the version number. As a side note, the snapshot tests via testthat are skipped on CRAN by default because it is not executed if not |
It appears there is a hard limit of 20 minutes on compiling the package on CRAN |
…th-r-in-the-package-title
…ge-package-name-title-or-similar-in-the-description
…ge-package-name-title-or-similar-in-the-description
Merge branch 'main' into 0.7.0rc # Conflicts: # tests/testthat/test-info.R
Merge branch 'main' into 0.7.0rc # Conflicts: # NEWS.md
NOTE update with ctb's in DESCRIPTION as of #307 |
No that is just r-hub. You can't infer a limit at CRAN from r-hub -- but for CRAN most of what we know is in the CRAN Repository Policy page. Some larger packages ( |
@etiennebacher @eitsupi |
I have tried all except |
I have some concerns about CRAN and my personal future enthusiasm:
If hitting too many obstacles would it make sense to not think of r-polars as CRAN first. But rather have a script that packages polars also for CRAN in the "downgraded version". Then we could just drop any doc page asked for, hardcode the packaged MAKEVARS to drop SIMD feature etc. and invite users in a message to install the "full featured better version" in 20 secs and use the awesome online documentation. |
@eitsupi I think you would be a better CRAN/polars maintainer then I. I happily swap roles and/or follow your lead in these matters. |
I disagree, the default of Polars is to disable simd. |
Sorry I mean py-polars ship nightly with simd via pip. sorenwelling@Srens-MacBook-Pro rust % pip install polars --force
Collecting polars
Downloading polars-0.18.7-cp38-abi3-macosx_10_7_x86_64.whl (18.5 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 18.5/18.5 MB 6.8 MB/s eta 0:00:00
Installing collected packages: polars
Attempting uninstall: polars
Found existing installation: polars 0.18.4
Uninstalling polars-0.18.4:
Successfully uninstalled polars-0.18.4
Successfully installed polars-0.18.7
sorenwelling@Srens-MacBook-Pro rust % python
Python 3.10.9 (main, Dec 15 2022, 18:18:30) [Clang 14.0.0 (clang-1400.0.29.202)] on darwin
Type "help", "copyright", "credits" or "license" for more information. >>> import polars as pl
>>> pl.build_info()
{'build': {'rustc': '/Users/runner/.rustup/toolchains/nightly-2023-06-23-x86_64-apple-darwin/bin/rustc', 'rustc-version': 'rustc 1.72.0-nightly (04075b320 2023-06-22)', 'opt-level': '3', 'debug': False, 'jobs': 3}, 'info-time': datetime.datetime(2023, 7, 12, 19, 12, 30, tzinfo=datetime.timezone.utc), 'dependencies': {'adler': '1.0.2', 'adler32': '1.2.0', 'ahash': '0.8.3', 'aho-corasick': '1.0.1', 'alloc-no-stdlib': '2.0.4', 'alloc-stdlib': '0.2.2', 'allocator-api2': '0.2.15', 'android-tzdata': '0.1.1', 'android_system_properties': '0.1.5', 'argminmax': '0.6.1', 'array-init-cursor': '0.2.0', 'arrow-format': '0.8.1', 'arrow2': '0.17.1', 'async-stream': '0.3.5', 'async-stream-impl': '0.3.5', 'async-trait': '0.1.68', 'atoi': '2.0.0', 'autocfg': '1.1.0', 'avro-schema': '0.3.0', 'base64': '0.21.2', 'bitflags': '1.3.2', 'brotli': '3.3.4', 'brotli-decompressor': '2.3.4', 'built': '0.6.0', 'bumpalo': '3.13.0', 'bytemuck': '1.13.1', 'bytemuck_derive': '1.4.1', 'bytes': '1.4.0', 'cargo-lock': '8.0.3', 'cc': '1.0.79', 'cfg-if': '1.0.0', 'chrono': '0.4.26', 'chrono-tz': '0.8.2', 'chrono-tz-build': '0.1.0', 'ciborium': '0.2.1', 'ciborium-io': '0.2.1', 'ciborium-ll': '0.2.1', 'comfy-table': '7.0.1', 'core-foundation-sys': '0.8.4', 'crc': '2.1.0', 'crc-catalog': '1.1.1', 'crc32fast': '1.3.2', 'crossbeam-channel': '0.5.8', 'crossbeam-deque': '0.8.3', 'crossbeam-epoch': '0.9.14', 'crossbeam-queue': '0.3.8', 'crossbeam-utils': '0.8.15', 'crossterm': '0.26.1', 'crossterm_winapi': '0.9.0', 'dyn-clone': '1.0.11', 'either': '1.8.1', 'enum_dispatch': '0.3.11', 'equivalent': '1.0.0', 'ethnum': '1.3.2', 'fallible-streaming-iterator': '0.1.9', 'fast-float': '0.2.0', 'flate2': '1.0.26', 'float-cmp': '0.9.0', 'foreign_vec': '0.1.0', 'form_urlencoded': '1.1.0', 'futures': '0.3.28', 'futures-channel': '0.3.28', 'futures-core': '0.3.28', 'futures-executor': '0.3.28', 'futures-io': '0.3.28', 'futures-macro': '0.3.28', 'futures-sink': '0.3.28', 'futures-task': '0.3.28', 'futures-util': '0.3.28', 'getrandom': '0.2.9', 'ghost': '0.1.9', 'git2': '0.16.1', 'glob': '0.3.1', 'half': '1.8.2', 'halfbrown': '0.2.2', 'hash_hasher': '2.0.3', 'hashbrown': '0.14.0', 'heck': '0.4.1', 'hermit-abi': '0.2.6', 'hex': '0.4.3', 'home': '0.5.5', 'iana-time-zone': '0.1.56', 'iana-time-zone-haiku': '0.1.2', 'idna': '0.3.0', 'indexmap': '2.0.0', 'indoc': '1.0.9', 'instant': '0.1.12', 'inventory': '0.3.6', 'itoa': '1.0.6', 'itoap': '1.0.1', 'jemalloc-sys': '0.5.3+5.3.0-patched', 'jemallocator': '0.5.0', 'jobserver': '0.1.26', 'js-sys': '0.3.63', 'jsonpath_lib': '0.3.0', 'lexical': '6.1.1', 'lexical-core': '0.8.5', 'lexical-parse-float': '0.8.5', 'lexical-parse-integer': '0.8.6', 'lexical-util': '0.8.5', 'lexical-write-float': '0.8.5', 'lexical-write-integer': '0.8.5', 'libc': '0.2.144', 'libflate': '1.4.0', 'libflate_lz77': '1.2.0', 'libgit2-sys': '0.14.2+1.5.1', 'libm': '0.2.7', 'libmimalloc-sys': '0.1.33', 'libz-sys': '1.1.9', 'lock_api': '0.4.9', 'log': '0.4.18', 'lz4': '1.24.0', 'lz4-sys': '1.9.4', 'matrixmultiply': '0.3.7', 'memchr': '2.5.0', 'memmap2': '0.5.10', 'memoffset': '0.9.0', 'mimalloc': '0.1.37', 'miniz_oxide': '0.7.1', 'mio': '0.8.8', 'multiversion': '0.7.2', 'multiversion-macros': '0.7.2', 'ndarray': '0.15.6', 'now': '0.1.3', 'ntapi': '0.4.1', 'num-complex': '0.4.3', 'num-integer': '0.1.45', 'num-traits': '0.2.15', 'num_cpus': '1.15.0', 'numpy': '0.19.0', 'once_cell': '1.17.2', 'parking_lot': '0.12.1', 'parking_lot_core': '0.9.7', 'parquet-format-safe': '0.2.4', 'parquet2': '0.17.2', 'parse-zoneinfo': '0.3.0', 'percent-encoding': '2.2.0', 'phf': '0.11.1', 'phf_codegen': '0.11.1', 'phf_generator': '0.11.1', 'phf_shared': '0.11.1', 'pin-project-lite': '0.2.9', 'pin-utils': '0.1.0', 'pkg-config': '0.3.27', 'planus': '0.3.1', 'polars': '0.30.0', 'polars-algo': '0.30.0', 'polars-arrow': '0.30.0', 'polars-core': '0.30.0', 'polars-error': '0.30.0', 'polars-io': '0.30.0', 'polars-json': '0.30.0', 'polars-lazy': '0.30.0', 'polars-ops': '0.30.0', 'polars-pipe': '0.30.0', 'polars-plan': '0.30.0', 'polars-row': '0.30.0', 'polars-sql': '0.30.0', 'polars-time': '0.30.0', 'polars-utils': '0.30.0', 'ppv-lite86': '0.2.17', 'proc-macro2': '1.0.59', 'py-polars': '0.18.7', 'pyo3': '0.19.0', 'pyo3-build-config': '0.19.0', 'pyo3-built': '0.4.7', 'pyo3-ffi': '0.19.0', 'pyo3-macros': '0.19.0', 'pyo3-macros-backend': '0.19.0', 'quote': '1.0.28', 'rand': '0.8.5', 'rand_chacha': '0.3.1', 'rand_core': '0.6.4', 'rand_distr': '0.4.3', 'rawpointer': '0.2.1', 'rayon': '1.7.0', 'rayon-core': '1.11.0', 'redox_syscall': '0.2.16', 'regex': '1.8.3', 'regex-syntax': '0.7.2', 'rle-decode-fast': '1.0.3', 'rustc-hash': '1.1.0', 'rustc_version': '0.4.0', 'rustversion': '1.0.12', 'ryu': '1.0.13', 'scopeguard': '1.1.0', 'semver': '1.0.17', 'seq-macro': '0.3.3', 'serde': '1.0.163', 'serde_derive': '1.0.163', 'serde_json': '1.0.96', 'signal-hook': '0.3.15', 'signal-hook-mio': '0.2.3', 'signal-hook-registry': '1.4.1', 'simd-json': '0.10.3', 'simdutf8': '0.1.4', 'siphasher': '0.3.10', 'slab': '0.4.8', 'smallvec': '1.10.0', 'smartstring': '1.0.1', 'snap': '1.1.0', 'socket2': '0.4.9', 'sqlparser': '0.34.0', 'static_assertions': '1.1.0', 'streaming-decompression': '0.1.2', 'streaming-iterator': '0.1.9', 'strength_reduce': '0.2.4', 'strum': '0.24.1', 'strum_macros': '0.25.0', 'syn': '2.0.18', 'sysinfo': '0.29.0', 'target-features': '0.1.4', 'target-lexicon': '0.12.7', 'thiserror': '1.0.40', 'thiserror-impl': '1.0.40', 'time': '0.1.45', 'tinyvec': '1.6.0', 'tinyvec_macros': '0.1.1', 'tokio': '1.28.2', 'toml': '0.5.11', 'unicode-bidi': '0.3.13', 'unicode-ident': '1.0.9', 'unicode-normalization': '0.1.22', 'unicode-width': '0.1.10', 'unindent': '0.1.11', 'url': '2.3.1', 'value-trait': '0.6.1', 'vcpkg': '0.2.15', 'version_check': '0.9.4', 'wasi': '0.11.0+wasi-snapshot-preview1', 'wasm-bindgen': '0.2.86', 'wasm-bindgen-backend': '0.2.86', 'wasm-bindgen-futures': '0.4.36', 'wasm-bindgen-macro': '0.2.86', 'wasm-bindgen-macro-support': '0.2.86', 'wasm-bindgen-shared': '0.2.86', 'wasm-timer': '0.2.5', 'web-sys': '0.3.63', 'winapi': '0.3.9', 'winapi-i686-pc-windows-gnu': '0.4.0', 'winapi-x86_64-pc-windows-gnu': '0.4.0', 'windows': '0.48.0', 'windows-sys': '0.48.0', 'windows-targets': '0.48.0', 'windows_aarch64_gnullvm': '0.48.0', 'windows_aarch64_msvc': '0.48.0', 'windows_i686_gnu': '0.48.0', 'windows_i686_msvc': '0.48.0', 'windows_x86_64_gnu': '0.48.0', 'windows_x86_64_gnullvm': '0.48.0', 'windows_x86_64_msvc': '0.48.0', 'xxhash-rust': '0.8.6', 'zstd': '0.12.3+zstd.1.5.2', 'zstd-safe': '6.0.5+zstd.1.5.4', 'zstd-sys': '2.0.8+zstd.1.5.5'}, 'features': ['ALL', 'ASOF_JOIN', 'AVRO', 'BINARY_ENCODING', 'BUILD_INFO', 'CROSS_JOIN', 'CSE', 'CSV', 'CUTQCUT', 'DECOMPRESS', 'DEFAULT', 'EXTRACT_JSONPATH', 'IPC', 'IS_IN', 'JSON', 'LAZY_REGEX', 'LIST_ANY_ALL', 'LIST_COUNT', 'LIST_SETS', 'LIST_TAKE', 'MERGE_SORTED', 'META', 'NIGHTLY', 'OBJECT', 'PARQUET', 'PCT_CHANGE', 'PERFORMANT', 'PIVOT', 'PROPAGATE_NANS', 'REPEAT_BY', 'RLE', 'SEARCH_SORTED', 'SERDE_JSON', 'SIGN', 'SQL', 'STREAMING', 'TIMEZONES', 'TOP_K', 'TRIGONOMETRY'], 'host': {'triple': 'x86_64-apple-darwin'}, 'target': {'arch': 'x86_64', 'os': 'macos', 'family': 'unix', 'env': '', 'triple': 'x86_64-apple-darwin', 'endianness': 'little', 'pointer-width': '64', 'profile': 'release'}, 'git': {'version': 'py-0.18.7', 'dirty': True, 'hash': '96b0e07e75a882eaed7be05e619307bc144aa5b4', 'head': None}, 'version': '0.18.7'} |
(FWIW I found SIMD is generally supported and eg package RcppSimdJson checks entirely at run-time which is most portable. We have run into issues with newer chipsets and AVX512 but only in cases where pre-made libraries are consumed. If you compile on the spot the toolchain generally knows.) |
Thanks for the information. |
Okay, I will submit 29a57de to CRAN. Let's see what happens with that. (BTW, I'm packing up my development PC for the move, so I won't be able to do any development work for the next few days.) |
Fantastic! @sorhawell @etiennebacher For now, do you think it would be a good idea to merge this as is for now and tag the merged commit? |
Wow. Long live the new maintainer ! |
yeah with a tag and squash I guess this is ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Very close. |
Sorry for the delay on my notification. I received two emails as follows. I think we need to merge this for now, release 0.7.0, and remove the installation instructions from CRAN from the README in a follow-up PR (sorry but I don't have the bandwidth to work on that for a while)
|
Does that mean list authors of all crates? |
Yes, please check this post and the |
@sorhawell Could you push the tag and create the GitHub release? |
@sorhawell I think you made a mistake in tagging the wrong commit. I deleted the release and tag and pushed a new tag again. |
No description provided.