-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Bump rust-polars to 0.37.0 #776
Conversation
Thank you for working on this. I haven't done anything yet and don't have enough time right away, so it would be helpful if you could move forward. |
I think the toolchain version should be updated. |
Note: pola-rs/polars#14026 should affect S3 methods for operators. |
The only failing tests are related to conversion from arrow to polars. This is probably related to the new binview format. There is a new argument |
I think it's probably because the schema and actual type were different that caused the segmentation fault. |
@etiennebacher I believe I have made corrections so that it passes all tests. |
Cool, thanks. Yes I'll take care of the NEWS and I'll add some deprecations warnings. I'll ping you when ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm off to bed, so feel free to merge this in anytime. (we can always open a follow up PRs, so the sooner you merge the better, I think)
https://github.com/pola-rs/polars/releases/tag/rs-0.37.0
@eitsupi if you already started working on this, I can close this and let you open a new PR