-
Notifications
You must be signed in to change notification settings - Fork 32
Tidying #153
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
=======================================
Coverage 99.28% 99.28%
=======================================
Files 12 12
Lines 837 837
=======================================
Hits 831 831
Misses 6 6 ☔ View full report in Codecov by Sentry. |
Lint GitHub Action fails because it doesn't have read and write permission to make commits:
See top comment to apply the required change to allow the action to make commits. After doing so re-run the action and all checks should pass. |
Reading from the UI, these are the default permissions. "You can specify more granular permissions in the workflow using YAML." Can't we just change the YAML? |
Also while we're at it... is this essentially equivalent to https://pre-commit.ci/ ? |
Sure, can you set a new secrets.WORKFLOW_TOKEN (see here).
Yep. The only reason why I added pre-commit was to use the end-of-file-fixer and trailing-whitespace automations they have. If you want I can move ruff into the pre-commit config file too and have all linting done from there. |
ruff format -diff
.tox -e reformat
from readme.