Skip to content
This repository has been archived by the owner on Dec 16, 2024. It is now read-only.

Refresh and types #76

Closed
wants to merge 3 commits into from
Closed

Refresh and types #76

wants to merge 3 commits into from

Conversation

astrojuanlu
Copy link
Member

  • Converted some classes to auto_attribs=True to enhance type checking
  • Almost fully strict MyPy mode

Still lots of TODOs, untested stuff, open questions... But it's a good start, I think. Will leave this open for a few weeks because it's unlikely that I'll be able to work on this in the immediate future, but at least it will serve as inspiration to others until I finish it.

Non-systematic approach, only made tests pass.
Added numerous TODOs for future reference.
Base automatically changed from master to main March 11, 2021 09:23
@Sedictious
Copy link
Member

Hello @astrojuanlu are you planning on continuing to work on this? If you want, I could try rebasing and continuing with the rest of the classes

@astrojuanlu
Copy link
Member Author

I don't intend to keep working on this 🙏🏽 I had many open questions about what the best way to proceed would be.

to begin with, I love attrs but the whole @attr.s(auto_attribs=True, repr=False, frozen=True) was a bit annoying. maybe dataclasses is simpler? or even pydantic these days?

on the other hand, maybe the whole codebase should be automatically generated #81 from the schema, but I never made progress with that. the thing is that the CZML3 spec can produce very nested objects that are cumbersome to build.

this is an open problem for whoever takes over.

@astrojuanlu astrojuanlu closed this by deleting the head repository Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants