[AHM] Conviction Voting Pallet #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
reviewed
Feb 5, 2025
| if Pallet::<T>::is_empty_conviction_vote(&voting) { | ||
| // from the Polkadot 17.01.2025 snapshot 20575 records | ||
| // issue: https://github.com/paritytech/polkadot-sdk/issues/7458 | ||
| log::info!( |
There was a problem hiding this comment.
We need some good testing to ensure that this does not break other stuff. Will note it.
There was a problem hiding this comment.
If the issue I created wont be solved before, I will add tests. Or we have proof from that issue that I am right here.
23 tasks
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
64 tasks
ggwpez
merged commit 1b82e0a
into
polkadot-fellows:dev-asset-hub-migration
28 of 48 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meant to be merged into ahm dev branch
The data migration for the conviction-voting pallet.