Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: showing what core the chain is renewed on #11256

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

piggydoughnut
Copy link
Contributor

  • Fixed not showing "renewed"
  • Added what core the chain was renewed on.
Screenshot 2025-02-03 at 7 29 05 PM

@TarikGul
Copy link
Member

TarikGul commented Feb 3, 2025

Question what is the something renewed on <something> mean?

I know its referring to the core - but I am confused on what that means seeing that other cores overlap.

@piggydoughnut
Copy link
Contributor Author

@TarikGul
Renewed on X, is indeed on core X. Chains do not always get the same core when they renew, they can be allocated anything. So the will "migrate" to another core.

I m not sure what you mean by overlap. Do you mean that it says "renewed on 13", but there is a chain on 13 right now?
In that case maybe we could put something like. "Next cycle on core 6"

@TarikGul
Copy link
Member

TarikGul commented Feb 4, 2025

@TarikGul Renewed on X, is indeed on core X. Chains do not always get the same core when they renew, they can be allocated anything. So the will "migrate" to another core.

I m not sure what you mean by overlap. Do you mean that it says "renewed on 13", but there is a chain on 13 right now? In that case maybe we could put something like. "Next cycle on core 6"

Yea That is exactly what I meant by overlap. I think something referring to it being the next cycle would help clear confusion, since I was confused when reading it initially.

@piggydoughnut
Copy link
Contributor Author

@TarikGul good point! I updated the wording. Should be better now.

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@TarikGul TarikGul merged commit e5b2b48 into master Feb 5, 2025
5 checks passed
@TarikGul TarikGul deleted the bug/coretime/11253-not-showing-renewed branch February 5, 2025 11:36
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants