Chore: Remove missing global fail() function from tests #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pileks
requested review from
nerfZael,
dOrgJelli,
krisbitney and
namesty
as code owners
dOrgJelli
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Jest's newish
circusrunner, the globalfail()function no longer exists, although it is present in@types/jest, due to its presence in thejest-jasmine2runner which has been replaced bycircusas the default runner.In this PR, I have opted to clean up our tests by removing calls to
fail()and replacing them with proper assertions.This also simplifies our testing infrastructure, making it more resilient to changes in our
Resulttype by leveraging comparison assertions usingResultOKandResultErr.