forked from michielbdejong/server
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mrv/mfa check final #328
Open
mrvahedi68
wants to merge
209
commits into
master
Choose a base branch
from
mrv/mfa-check-final
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Mrv/mfa check final #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <[email protected]>
…ability. Signed-off-by: Faraz Samapoor <[email protected]> Signed-off-by: Faraz Samapoor <[email protected]>
Co-authored-by: Côme Chilliet <[email protected]> Signed-off-by: Faraz Samapoor <[email protected]> Signed-off-by: Faraz Samapoor <[email protected]>
Signed-off-by: MohammadReza vahedi <[email protected]>
Signed-off-by: MohammadReza vahedi <[email protected]>
Signed-off-by: MohammadReza vahedi <[email protected]>
Signed-off-by: MohammadReza vahedi <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
@@ -148,12 +143,18 @@ | |||
}); | |||
|
|||
// notifications api to accept incoming user shares | |||
$oldDispatcher->addListener('OCP\Share::postShare', function (OldGenericEvent $event) { | |||
$dispatcher->addListener('OCP\Share::postShare', function ($event) { | |||
if (!$event instanceof OldGenericEvent) { |
Check notice
Code scanning / Psalm
RedundantConditionGivenDocblockType
OCP\EventDispatcher\Event does not contain Symfony\Component\EventDispatcher\GenericEvent
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: hamza221 <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
Signed-off-by: Daniel Kesselberg <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
This should be handled when mapping groups, not when registering their members. An empty group may still exist. Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
…de-symfony/event-dispatcher fix(deps)!: Upgrade symfony/event-dispatcher to supported version 5.4.26
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
log imaginary errors as info to not spam the server logs
Signed-off-by: Daniel Kesselberg <[email protected]>
APC is gone since PHP 7.0. Signed-off-by: Daniel Kesselberg <[email protected]>
docs: remove superfluous phpdocs
…tor-group-membership-cache Refactor user_ldap group membership cache and add check-group command
…on-version-check chore: remove version check for apc extension
AppEcosystem Authentification
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
enh(files_reminders): Adjust reminder options
Signed-off-by: Nextcloud bot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist