Remove duplicate code #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is really just a wrapper around produceOutput(). While currently, all parameters are constant strings, there's no real reason to hardcode the format string in waitThenAction() anymore. As a bonus, this small change allows us to get rid of the cost of formatting a few extra strings.
These functions are almost identical. No need to reimplement the same thing twice.
The pointer s is obtained from sessions[sessionId] and is never changed within this function. No need to reassign s to sessions[sessionId].
lfos
force-pushed
the
remove-duplicate-code
branch
from
db2d7f8 to
14d2a9c
Compare
Closed
|
reads fine, will test shortly and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three patches to remove a few instances of duplicate code.