Fix preview kill on drop (ordinals#1260)

popcnt1 · Jan 16, 2023 · db765e9 · db765e9
1 parent 8f203ae
commit db765e9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/src/subcommand/preview.rs b/src/subcommand/preview.rs
@@ -11,11 +11,7 @@ struct KillOnDrop(process::Child);
 
 impl Drop for KillOnDrop {
   fn drop(&mut self) {
-    Command::new("kill")
-      .arg("-SIGINT")
-      .arg(self.0.id().to_string())
-      .spawn()
-      .expect("failed to SIGINT kill process");
+    self.0.kill().unwrap()
   }
 }
 

diff --git a/tests/core.rs b/tests/core.rs
@@ -4,11 +4,11 @@ struct KillOnDrop(std::process::Child);
 
 impl Drop for KillOnDrop {
   fn drop(&mut self) {
-    Command::new("kill")
-      .arg("-SIGINT")
+    assert!(Command::new("kill")
       .arg(self.0.id().to_string())
-      .spawn()
-      .expect("failed to SIGINT kill process");
+      .status()
+      .unwrap()
+      .success());
   }
 }