Refactor console reducer to use handleActions, test with Jest #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwang1919
suggested changes
May 9, 2019
outoftime
commented
May 13, 2019
Migrates the console reducer to use `handleActions` rather than hand-rolled reducer logic built around a `switch` statement. Uses action creators as keys (which is something `redux-actions` explicitly affords) to reduce repetition of magic action type constant strings.
Per Jest recommendations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce two patterns to the console reducers that we would like to eventually use for all reducers:
handleActions()rather than a hand-rolled switch statement; these use the action creators themselves as keys to avoid hard-coding constant names