Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebalancing via saving plans #2504

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

RomanLangrehr
Copy link
Contributor

This adds a new column to the rebalancing viewer that shows the required saving plan sums to rebalance the portfolio.

It also adds one line above the table where you can enter the saving plan sum (can be negative for a withdrawal plan) and the number of executions of the savings plan it should take to rebalance the portfolio. I planned to make this line disappear when the "savings plan sum" column is hidden, but unfortunately I didn't manage to implement this because I couldn't figure out a way to get notified when a column is shown or hidden.

image

@chirlu
Copy link
Member

chirlu commented Nov 7, 2021

The use case for that would be “I want to run a savings plan, and I’m not allowed to change the distribution over the assets for the next X months”? Hm.

So I don’t really see (yet) that being able to specify a number of months would be particularly useful. But a lump sum, with the provision that no assets are to be sold (or bought, for a withdrawal plan), certainly is – there were a number of requests for that on the forums: e.g. https://forum.portfolio-performance.info/t/rebalance-among-asset-classes-with-just-cash-and-not-selling-off-any-securities/17815, https://forum.portfolio-performance.info/t/rebalancing-mit-portfolio-performance/19/22, https://forum.portfolio-performance.info/t/entnahme-mit-rebalancing/12744

I’m somewhat worried people looking for a “lump sum feature” won’t find a “savings plan feature” with the special case months = 1. My suggestion would therefore be to omit the “months” option, which would allow renaming things. Unless, of course, there really is a use case for the savings plan.


Related: Some people asked for the amount of fresh money that would be necessary to do a full rebalancing without selling anything. I’m not too convinced of the usefulness, though – even when I know that € 12345,67, I can’t simply draw that money from thin air …

@RomanLangrehr
Copy link
Contributor Author

Unless, of course, there really is a use case for the savings plan.

In my point of view, there is. At least I have monthly saving plans (and want to use them for rebalancing), but I don't want to adapt the savings plan sum every month (but rather every quarter or every 6 months), just because it would be to annoying to do this every month and there is no drawback in doing it a bit less often.

# Conflicts:
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/Messages.java
@RomanLangrehr
Copy link
Contributor Author

@buchen This PR hasn't made it into PP so far. May I ask why? Is there something that should be done before or is this feature just not desired?

@RomanLangrehr RomanLangrehr force-pushed the rebalancing-via-saving-plans branch from ea66d4c to 81a8011 Compare September 17, 2022 22:07
# Conflicts:
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/Messages.java
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages.properties
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages_cs.properties
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages_es.properties
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages_fr.properties
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages_it.properties
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages_nl.properties
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages_pt.properties
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages_ru.properties
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages_sk.properties
# Conflicts:
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/Messages.java
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages.properties
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages_cs.properties
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages_es.properties
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages_fr.properties
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages_it.properties
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages_nl.properties
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages_pt.properties
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages_ru.properties
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages_sk.properties
# Conflicts:
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages_de.properties
#	name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/messages_nl.properties
@auchri
Copy link
Contributor

auchri commented May 2, 2024

@buchen ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants