js: Make language code handling more robust, add tests #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differing internal representations of two-level language codes, e.g. pt_BR/pt_PT or zh_CN/zh_TW, would lead to inconsistencies when combined with overrides of i18n strings for templating. E.g. setting data-isso-lang=pt_BR and data-isso-postbox-text-text-PT_BR would result in an internal representation of data-isso-postbox-text-text-pt-br (note: lowercase) and thus user-supplied i18n strings not being applied. To make this handling more robust, convert everything into lowercase and substitute underscores for dashes. Fixes isso-comments#982
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.rstbecause this is a user-facing change or an important bugfixjs: Make lang code handling more robust in config
Differing internal representations of two-level language codes, e.g.
pt_BR/pt_PTorzh_CN/zh_TW, would lead to inconsistencies when combined with overrides of i18n strings for templating.E.g. setting
data-isso-lang=pt_BRanddata-isso-postbox-text-text-PT_BR=foowould result in an internal representation ofdata-isso-postbox-text-text-pt-br(note: lowercase) and thus user-supplied i18n strings not being applied.To make this handling more robust, convert everything into lowercase and substitute underscores for dashes.
Fixes #982
js: test/unit: Add testing for i18n overrides
Add jest tests