You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
rstudioapi::getThemeInfo() was not included in the initial list of shimmed rstudioapi functions in #1312.
It'd be nice to support this function, in particular because it's used by thematic and would enable automatic theming of plots to reflect the current Positron theme.
I just moved this into release candidate, because I'm about to make a change in reprex that won't fully take effect in Positron, until we offer rstudioapi::getThemeInfo().
In reprex's case, it's dark (TRUE / FALSE) that is really important, so a bit different from @gadenbuie's priorities.
We discussed this briefly in the R sync today, so I'll leave a few notes for whoever picks this up:
We suspect returning "Modern" for the global theme is the right call. It is a concept that doesn't really map over to VS Code / Positron, so this is going to be somewhat artificial.
Implementation will probably look a lot like the existing implementation of evaluate_when_clause in the ui comm.
Positron doesn't support dark vs. light mode detection from R yet (posit-dev/positron#2986), but reprex will just use light mode unconditionally for now. Which is still better than the current fugliness.
* This wasn't doing anything anyway.
The reason we have had syntax highlighting in the html preview is because of some styling added at the end of the github css.
* Add a helper to detect dark mode
Positron doesn't support dark vs. light mode detection from R yet (posit-dev/positron#2986), but reprex will just use light mode unconditionally for now. Which is still better than the current fugliness.
* Grab github CSS: the opening move
* Fixup the github CSS for our application
* Take github css from here, in reprex; stop using a template
* Add a custom syntax highlighting theme
* Vendor the R syntax definition
* Fixup r.xml
* Install pandoc in the test-coverage job
* Go back to `verbose = FALSE`
rstudioapi::getThemeInfo()
was not included in the initial list of shimmed rstudioapi functions in #1312.It'd be nice to support this function, in particular because it's used by
thematic
and would enable automatic theming of plots to reflect the current Positron theme.Here's the info currently available in RStudio
In particular, the key bits that I'd like to see in Positron:
foreground
background
dark
(would be nice)editor
(would be nice)I don't think we'd need the
global
item, or that could be"Positron"
.The text was updated successfully, but these errors were encountered: