Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows tests to the PR CI workflow #5935

Closed
jonvanausdeln opened this issue Jan 9, 2025 · 0 comments
Closed

Add Windows tests to the PR CI workflow #5935

jonvanausdeln opened this issue Jan 9, 2025 · 0 comments
Assignees
@jonvanausdeln
Labels
area: qa infrastructure testing Unit, extension-level, and smoke tests
Milestone
2025.02.0 Pre-Rel...

Comments

@jonvanausdeln
Copy link
Contributor

We need to add a windows job to the PR workflow. There are occasionally features and tests that behave differently on Windows and since most of the team is on MacOS, these can easily slip through the cracks.
@jonvanausdeln jonvanausdeln added area: qa infrastructure testing Unit, extension-level, and smoke tests labels Jan 9, 2025
@jonvanausdeln jonvanausdeln added this to the 2025.02.0 Pre-Release milestone Jan 9, 2025
@jonvanausdeln jonvanausdeln self-assigned this Jan 9, 2025
This was referenced Jan 10, 2025
Closed
Merged
jonvanausdeln added a commit that referenced this issue Jan 13, 2025
@jonvanausdeln
Add windows and browser job to PR workflow (#5940)
d786dc5 
Addresses #5935 and #5955
This adds windows and web tests to the PR workflow.  They are by default turned off, but can be added with the `win` and `web` tags.  
    
### QA Notes
I tested with and without the win and web tags. It also works in conjunction with other tags.

@:win @:web
<!--
  Add additional information for QA on how to validate the change,
  paying special attention to the level of risk, adjacent areas that
  could be affected by the change, and any important contextual
  information not present in the linked issues.
-->
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonvanausdeln jonvanausdeln

Labels
area: qa infrastructure testing Unit, extension-level, and smoke tests
Projects
None yet
Milestone
2025.02.0 Pre-Release
Development

No branches or pull requests
1 participant
@jonvanausdeln