fix(link-tracking): Fixed unsubscribe links when click tracking is en…

…abled
postalsys · Aug 28, 2024 · 34cdc38 · 34cdc38
1 parent 93a7010
commit 34cdc38
Showing 1 changed file with 29 additions and 1 deletion.
diff --git a/lib/add-trackers.js b/lib/add-trackers.js
@@ -1,5 +1,7 @@
 'use strict';
 
+const he = require('he');
+
 const { rewriteTextNodes } = require('./rewrite-text-nodes');
 
 const { getSignedFormDataSync, getServiceSecret } = require('./tools');
@@ -48,6 +50,27 @@ async function addClickTrackers(html, account, messageId, baseUrl) {
     html = html.replace(/(<a[^>]* href\s*=[\s"']*)(http[^"'>\s]+)/gi, (match, prefix, url) => {
         const redirectUrl = new URL('redirect', baseUrl);
 
+        try {
+            url = he.decode(url);
+        } catch (err) {
+            // ???
+        }
+
+        // check if we need to rewrite the URL
+        try {
+            let parsedUrl = new URL(url);
+            if (parsedUrl.origin === redirectUrl.origin) {
+                switch (parsedUrl.pathname) {
+                    case '/unsubscribe':
+                    case '/redirect':
+                        // do not rewrite the URL
+                        return match;
+                }
+            }
+        } catch (err) {
+            // ???
+        }
+
         let { data, signature } = getSignedFormDataSync(
             serviceSecret,
             {
@@ -64,7 +87,12 @@ async function addClickTrackers(html, account, messageId, baseUrl) {
             redirectUrl.searchParams.append('sig', signature);
         }
 
-        return prefix + redirectUrl.href;
+        return (
+            prefix +
+            he.encode(redirectUrl.href, {
+                useNamedReferences: true
+            })
+        );
     });
 
     return html;