Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect calc reduction of 0 - (A - B) / C #88

Closed
bakkerjoeri opened this issue Jul 25, 2019 · 2 comments · Fixed by #93
Closed

Incorrect calc reduction of 0 - (A - B) / C #88

bakkerjoeri opened this issue Jul 25, 2019 · 2 comments · Fixed by #93

Comments

@bakkerjoeri
Copy link

Given the following CSS:

left: calc(0px - (100vw - 10px) / 2);

Which I expect to become:

left: calc((-100vw - - 10px) / 2);

Actually becomes the mathematically incorrect:

left: calc((-100vw - - 10px) / -2);

Calculations with the structure 0 - (A - B) / C are incorrectly reduced to (-A - -B) - C while the correct solve is (-A - -B) / C.
@alexander-akait
Copy link
Collaborator

bug, PR welcome

jasminexie added a commit to jasminexie/postcss-calc that referenced this issue Oct 1, 2019
@jasminexie
fix: incorrect reduction of subtraction from zero (postcss#88)
5338ae3
@jasminexie jasminexie mentioned this issue Oct 1, 2019
Merged
jasminexie added a commit to jasminexie/postcss-calc that referenced this issue Oct 1, 2019
@jasminexie
fix(tests): add more tests for '0 - something' case (postcss#88)
6774ad8
alexander-akait pushed a commit that referenced this issue Oct 1, 2019
@jasminexie @evilebottnawi
fix: incorrect reduction of subtraction from zero (#88) (#93)
6260789
@bakkerjoeri
Copy link
Author

Hah, awesome! Thanks for picking this up @jasminexie 🎉

@snyk-bot snyk-bot mentioned this issue Mar 6, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Mar 23, 2020
Closed
@csr632 csr632 mentioned this issue Aug 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: incorrect reduction of subtraction from zero (#88) jasminexie/postcss-calc
2 participants
@bakkerjoeri @alexander-akait