Insert more needed parenthesis #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this PR? |
|
Any news? This bug is seriously blocking! 😰 |
|
Maybe someone could check this library to be inspired |
This was referenced Apr 7, 2021
|
I don't think approach is going to work, because it adds round brackets where there aren't any in the source, which can change the meaning, and it also add brackets around values which do not contain any variables and so could be simplified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #115
One thing that might be causing old tests to fail is that
calc(and the postcss-calc parser) is probably left-associative by default, so no parentheses are needed in cases like(a - b) - c.