Tests and fix for upstream css-color-function bug #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for a merge upstream. |
tylergaw
force-pushed
the
tint-shade-contrast-w-alpha-fix
branch
from
6a8c02f to
9df3b41
Compare
tylergaw
force-pushed
the
tint-shade-contrast-w-alpha-fix
branch
from
9df3b41 to
b0ecaba
Compare
|
I see css-color-function has been updated to 1.3.1 on npm. Is this safe to merge now, @tylergaw ? |
|
I’m confused. @tylergaw, regardless of the name (color vs color-mod), will these other fixes (breaking changes) make it into this PR? |
|
@jonathantneal Yeah, things bounced around a bit. I updated the description here. css-color-function 1.3.3 includes the fixes for the tint/shade adjusters and is backward compatible. There was a bit of a bump in versioning/breaking changes over there that you can read about in ianstormtaylor/css-color-function#34. I think this PR is ready to go with 1.3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for merge
Update 2017-10-09:
[email protected]Includes the tint/shade/contrast bug fix. This PR points to that tag now. Can ignore pretty much everything below.This PR points tomy forkthe 1.3.1 tag ofcss-color-function, so I'm guessing you'd want to wait until the npm package is updated, but wanted to go ahead and get the work in.Currently, there's a bug in
css-color-functionwhen using thetint,shade, andcontrastadjusters along with thealphaadjuster. This is due to it's use of themixfunction in the Color package it's using.I have a PR in for the fix there and added more detailed around the problem and solution ianstormtaylor/css-color-function#26This PR adds tests for the issues and I pushed one failure up so you can see what happens: https://travis-ci.org/tylergaw/postcss-color-function/builds/190518140
For now, I'm just pointing to my fork of css color function to see the code working/tests passing: https://travis-ci.org/tylergaw/postcss-color-function/builds/190518745
Once PR 26 gets merged I can update the dep here to use the og package.Update 2017-07-15
We merged PR/26 over in css-color-function
and created a 1.3.1 tag, but have not yet published it to NPM.This PR now points to Ian's og repo, directly to#1.3.1