Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition with [email protected] #1

Closed
clementnuss opened this issue Nov 24, 2021 · 1 comment
Closed

Race condition with [email protected] #1

clementnuss opened this issue Nov 24, 2021 · 1 comment

Comments

@clementnuss
Copy link
Contributor

clementnuss commented Nov 24, 2021 •
edited
Loading

More details here: kubernetes-sigs/controller-runtime#1442

It seems a race condition exists within controller-runtime. It might be important to have a look at it and determine if this could impact us, and if yes, whether we should change our approach.

Also, this breaks tests running with the -race argument, disabling it for the moment.
clementnuss added a commit that referenced this issue Nov 24, 2021
@clementnuss
build: removing race condition detection for tests
2c6b3cf 
related to #1
clementnuss added a commit that referenced this issue Dec 29, 2021
@clementnuss
chore: add back the -race test flag
0537fe3 
closes #1
@clementnuss
Copy link
Contributor Author

as the upstream issue with controller-runtime has been closed, this issue can be closed as well.

indeed, the go tests seem to run fine with the -race argument again, and other users reported that race condition issue they had before controller-runtime v0.11.x are gone now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clementnuss