Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cq: Run pylint from tox #979

Merged
merged 2 commits into from
Mar 2, 2021
Merged

cq: Run pylint from tox #979

merged 2 commits into from
Mar 2, 2021

Conversation

postlund
Copy link
Owner

In the past, pylint was run by tox but for some reason I removed it. Not
sure why. This commits adds pylint to tox again and fixes a few issues.

This PR fails due to two regressions in pylint:

pylint-dev/pylint#4123
pylint-dev/pylint#4131

Hopefully I will be able to merge this once those have been fixed. They are tagged for pylint 2.7.2 (next minor release), so hopefully it's not that far away.

@postlund postlund added the code quality Changes related to quality of code label Feb 24, 2021
@postlund postlund added this to the v0.8.0 milestone Feb 24, 2021
@postlund postlund self-assigned this Feb 24, 2021
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #979 (9529a17) into master (f0f7eaf) will increase coverage by 0.41%.
The diff coverage is 97.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #979      +/-   ##
==========================================
+ Coverage   95.71%   96.12%   +0.41%     
==========================================
  Files          40       40              
  Lines        3755     3846      +91     
==========================================
+ Hits         3594     3697     +103     
+ Misses        161      149      -12     
Flag Coverage Δ
unittests 96.12% <97.97%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyatv/dmap/tag_definitions.py 88.88% <ø> (ø)
pyatv/support/hap_tlv8.py 100.00% <ø> (ø)
pyatv/mrp/connection.py 84.53% <71.42%> (+2.43%) ⬆️
pyatv/support/mdns.py 88.00% <92.30%> (+0.10%) ⬆️
pyatv/support/dns.py 95.41% <96.49%> (+1.59%) ⬆️
pyatv/mrp/player_state.py 99.02% <98.00%> (+0.08%) ⬆️
pyatv/dmap/__init__.py 97.73% <98.24%> (+0.60%) ⬆️
pyatv/airplay/pairing.py 100.00% <100.00%> (ø)
pyatv/airplay/srp.py 97.16% <100.00%> (+0.02%) ⬆️
pyatv/const.py 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7464cb7...9529a17. Read the comment docs.

@postlund postlund force-pushed the pylint branch 2 times, most recently from 974b65f to 192adc7 Compare March 2, 2021 14:20
In the past, pylint was run by tox but for some reason I removed it. Not
sure why. This commits adds pylint to tox again and fixes a few issues.
@postlund postlund merged commit 1e1922e into master Mar 2, 2021
@postlund postlund deleted the pylint branch March 2, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Changes related to quality of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant